This comes up on views that use the default style plugin, but also if Semantic Views is in use: this is because we have this chain of method inheritance:

class views_object {
  function options() { }
}

class views_plugin extends views_object { }

class views_plugin_style extends views_plugin { }

class views_plugin_style_default extends views_plugin_style {
  function options(&$options) {
    parent::options($options);
  }
}

// And then in Semantic Views:

class semanticviews_plugin_style_default extends views_plugin_style {
  function options(&$options) {
    parent::options($options);
  }
}

We can't really fault Semantic Views for copying the signature of its immediate parent class, so I think the correct fix is to bring views_object::options() in line. (Though Semantic Views could do to just drop a method that merely calls its parent... ;)

views_object is the base class for all handlers and plugins, but in the Views codebase the options() method is only present in the hierarchy of display plugins I've given above, so there's no other subclasses that override it with the base class's signature.

Files: 
CommentFileSizeAuthor
#12411541.views_.strict-warning-display-plugin-options.patch402 bytesjoachim
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2411541.views_.strict-warning-display-plugin-options.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

joachim’s picture

 

Status:Active» Needs review
FileSize
402 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2411541.views_.strict-warning-display-plugin-options.patch. Unable to apply patch. See the log in the details link for more information. View

Here's a patch.

joachim’s picture

 

 

Status:Closed (duplicate)» Needs review

 

Status:Needs review» Needs work

The last submitted patch, 1: 2411541.views_.strict-warning-display-plugin-options.patch, failed testing.

 

Status:Needs work» Needs review

 

Status:Needs review» Needs work

The last submitted patch, 1: 2411541.views_.strict-warning-display-plugin-options.patch, failed testing.

SeanA’s picture

 

Status:Needs work» Closed (duplicate)
Holoduke’s picture

 

Perhaps it is duplicated, but last 6.2.18 at changelog show php 5.4 fixes applied but this bug is there yet. Look not fixed at the other post you linked. I manually changed the code and it is working now:
at /includes/base.inc
function options(<strong>&$options</strong>) { }

SeanA’s picture

 

It's fixed in the dev release; there hasn't been a stable release since then.

Holoduke’s picture

 

@holoduke, I tried your code change and I just get a WSOD. Any Ideas?